Ticket #2485 (closed defect: fixed)

Opened 8 years ago

Last modified 7 years ago

.xsh files have non-portable file names

Reported by: cjg Owned by: hjm03r
Priority: Intend to Milestone: WinPrints
Component: WinPrints Version:
Severity: blocker Keywords:
Cc:

Description

EPrints::DataObj::Document calls EPrints::Probity::create_log with a filename generated from EPrints::Utils::get_iso_timestamp. This filename contains ":" so is non-portable.

If this were changed to another character on all platforms (such as "_"), new filenames would not match old ones but bin/export_hashes would still work. Are .xsh files used anywhere else?

Alternatively the character used could be platform specific, but that would prevent transferring an archive from one platform to another.

Change History

Changed 8 years ago by hjm03r

  • severity changed from normal to major

This problem now affects EPrints::Time::get_iso_timestamp

Changed 7 years ago by hjm03r

  • severity changed from major to blocker

I avoid this in my working copy by just regexing s/:/_/g

Changed 7 years ago by cjg

OK. I suggest we make it a platform specific thing as it's better to cause a (teeny) problem moving over to windows from linux (you could safely just delete them all.

Changed 7 years ago by hjm03r

  • status changed from new to closed
  • resolution set to fixed

moj fixed this.

Note: See TracTickets for help on using tickets.