Ticket #2975 (closed defect: fixed)

Opened 7 years ago

Last modified 6 years ago

Can't press enter to perform simple search in IE 6 - works in Firefox

Reported by: tmb Owned by: tdb01r
Priority: Must do Milestone: EPrints 3.0.x (bugs go here)
Component: - Version:
Severity: normal Keywords:
Cc:

Description

Reported by NORA

Attachments

ie6simple_search.patch Download (0.8 KB) - added by tdb01r 6 years ago.
ie_submit_form_pressing_enter.patch Download (0.6 KB) - added by sf03r@… 6 years ago.
patch for the Search Perl Module

Change History

Changed 6 years ago by tdb01r

  • milestone changed from EPrints 3.1 beta to EPrints 3.0.4

Changed 6 years ago by tdb01r

  • owner set to tdb01r
  • status changed from new to assigned
  • milestone changed from EPrints 3.0.4 to EPrints 3.0.3

Nor does it work in IE7, but here's a solution  http://www.eprints.org/tech.php/8219.html

Changed 6 years ago by tdb01r

Changed 6 years ago by tdb01r

  • status changed from assigned to closed
  • resolution set to fixed

Resolved in r3045.

Changed 6 years ago by tmb

  • priority changed from Intend to to Must do
  • status changed from closed to reopened
  • resolution fixed deleted
  • milestone changed from EPrints 3.0.4 to EPrints 3.0.x (bugs go here)

Still does not work in IE6

Tested using 3.0.5 and 3.1.0-rc-1

Changed 6 years ago by sf03r@…

patch for the Search Perl Module

Changed 6 years ago by sf03r@…

Several patches need to be applied to fix this (kind of) bug:

- patch Perl Module so that searches are rendered with an extra hidden field which tricks EPrints into thinking that the Search button was pressed (actually it defined a default action which is 'search'). What you need for that is "ie_submit_form_pressing_enter.patch" attached to this ticket.

- patch static pages which have a search form (eg. frontpage, toolbar) to include the hidden field (that can be done manually really...)

Tim Brody's solution adds a hidden field called "_action_search", I added a hidden field called "_default_action". I don't know if one is better than the other, or if it matters at all.

Changed 6 years ago by tmb

From Chris Gutteridge:

Try editing Screen/AbstractSearch?.pm and adding this to the top of "sub from"

if( $self->{session}->have_parameters && !EPrints::Utils::is_set( $self->{processor}->{action} ) ) {

$self->{processor}->{action} = "search";

}

Changed 6 years ago by sf03r@…

Chris Gutteridge's solution is the one to use as his single change resolves all the problems (i.e. no need to worry about static forms like the one on the toolbar,frontpage).

Tested on 3.0.5 + IE6 and IE7

Changed 6 years ago by cjg

  • status changed from reopened to closed
  • resolution set to fixed

fixed in r3677

Note: See TracTickets for help on using tickets.