Ticket #3530 (closed defect: fixed)

Opened 6 years ago

Last modified 4 years ago

browse_link doesn't support new 'menus' configuration option

Reported by: af05v@… Owned by:
Priority: Priority Fix Milestone: EPrints 3.2.3
Component: - Version:
Severity: normal Keywords:
Cc:

Description

browse linking to a multiple browse view defined with the 'menus' style configuration creates a link to /view/viewname/value.html instead of /view/viewname/value/

Change History

Changed 5 years ago by af05v@…

  • priority changed from Must do to Priority Fix
  • milestone changed from EPrints 3.1.4 to EPrints 3.1.x

Changed 5 years ago by tmb

  • milestone changed from EPrints 3.1.x to EPrints 3.2.x (general bugs/features for 3.2)

Changed 5 years ago by tmb

In MetaField::render_value_no_multiple, replace:

 if( defined $linkview->{fields} && $linkview->{fields} =~ m/,/ )

with:

 if( ( defined $linkview->{fields} && $linkview->{fields} =~ m/,/ ) || ( defined $linkview->{menus} && scalar( @{ $linkview->{menus} } ) > 1 ) )

Changed 5 years ago by cjg

  • milestone changed from EPrints 3.2.x (general bugs/features for 3.2) to EPrints 3.2.2

Changed 5 years ago by tdb01r

  • status changed from new to closed
  • resolution set to worksforme

Appears to work in 3.2. Bug missing sample configuration anyway.

        {
            id => "subjects",
            menus => [
            {
                fields => [ "subjects" ],
                hideempty => 1,
            }
            ],
                order => "creators_name/title",
                include => 1,
                variations => [
                    "creators_name;first_letter",
                "type",
            ],  
        },

Changed 5 years ago by tmb

  • status changed from closed to reopened
  • resolution worksforme deleted

Here is an example of the bug in 3.2.1:

 http://demoprints.eprints.org/429/

Check out the Divisions link.

On the divisions field browse_link => divisions, but the rendering of this link doesn't take into account that the divisions view is multi-layered (ie. has more than one "menu") so should be sch_ecs/ not sch_ecs.html.

Changed 4 years ago by tdb01r

  • status changed from reopened to closed
  • resolution set to fixed

Fix applied.

Note: See TracTickets for help on using tickets.