Can't delete division using batch edit

[tmb]

"Delete values matching" gives a success message but doesn't actually remove the division.

[tdb01r]

Works in v3.2 (which is a complete re-write though).

[tmb]

 elsif( $action eq "delete" )
 {
     if( $field->get_property( "multiple" ) )
     {
         my $values = $object->get_value( $fieldname );
         my @$values = grep { cmp_deeply($value, $_) != 0 } @$values;
         $object->set_value( $fieldname, $values );

$value is an arrayref to $object->{data}->{$fieldname}

=> when $value is changed, $object->{data}->{$fieldname} gets changed.

=> when DataObj::set_value_raw compares $value and $object->{data}->{$fieldname} it doesn't think the value of $fieldname has changed.

Fix:

my $values = $object->get_value( $fieldname );
my @new_values = grep { cmp_deeply($value, $_) != 0 } @$values;
$object->set_value( $fieldname, \@new_values );

[tmb]

Above comment should read $values not $value:

$values is an arrayref to $object->{data}->{$fieldname}

=> when $values is changed, $object->{data}->{$fieldname} gets changed.

=> when DataObj::set_value_raw compares $values and $object->{data}->{$fieldname} it doesn't think the value of $fieldname has changed.

[tdb01r]

This is now:

my $values = EPrints::Utils::clone( $orig_value );
@$values = grep { cmp_deeply($value, $_) != 0 } @$values;
$field->set_value( $dataobj, $values );